[Hub Generated] Review request for Microsoft.MachineLearningServices to update version preview/2020-09-01-preview#12508
[Hub Generated] Review request for Microsoft.MachineLearningServices to update version preview/2020-09-01-preview#12508forteddyt wants to merge 89 commits intoAzure:masterfrom forteddyt:thtodoro/add-mfe
Conversation
|
Hi, @forteddyt Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
|
Hi @forteddyt, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @forteddyt your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
This should be in systemData. You shouldn't duplicate it inside the resource properties #Closed Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:8568 in 9f78980. [](commit_id = 9f78980, deletion_comment = False) |
please mark all managed identity properties readonly that are readonly Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9097 in 9f78980. [](commit_id = 9f78980, deletion_comment = False) |
this is not something you expose to the user. Please read through the managed identity implementation/contract docs one more time and ensure your contract is correct #Closed Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9085 in 9f78980. [](commit_id = 9f78980, deletion_comment = False) |
Don't use "type" as the discriminator on all these definitions. Change it to something more specific like "scheduleType" for schedules, etc... You got exceptions to use "tags", etc... within the property bag but there is no reason to duplicate all top level property names inside your property bag when you can easily use something else #Closed Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:10184 in 9f78980. [](commit_id = 9f78980, deletion_comment = False) |
Could you point me to the "managed identity implementation/contract docs"? |
|
Managed identity docs (more info in the table of contents in that same wiki section). https://armwiki.azurewebsites.net/authorization/managed_identities/MSIOnboardingSteps.html |
From my understanding, Managed Identities are updatable. Our service supports updating them, as well |
"principalId" and "tenantId" still need to be marked readonly In reply to: 808519549 [](ancestors = 808519549) Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9097 in 9f78980. [](commit_id = 9f78980, deletion_comment = False) |
"resourceId" and "tenantId" are not part of the contract. See https://armwiki.azurewebsites.net/authorization/managed_identities/MSIOnboardingUserAssigned.html#resource-definition-response Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:8849 in 3c977ff. [](commit_id = 3c977ff, deletion_comment = False) |
I've updated ResourceIdentityInArm's definition (alongside renaming it to ResourceIdentity) in c5e2292. Could you take a look and tell me if it's properly defined? I'll update the example files afterwards |
| <<<<<<< HEAD | ||
| openapi-type: arm | ||
| tag: package-2020-09-01-preview | ||
| ======= |
There was a problem hiding this comment.
Hey, looks like that we have some conflicts that are not correctly resolved here
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.