Skip to content

[Hub Generated] Review request for Microsoft.MachineLearningServices to update version preview/2020-09-01-preview#12508

Closed
forteddyt wants to merge 89 commits intoAzure:masterfrom
forteddyt:thtodoro/add-mfe
Closed

[Hub Generated] Review request for Microsoft.MachineLearningServices to update version preview/2020-09-01-preview#12508
forteddyt wants to merge 89 commits intoAzure:masterfrom
forteddyt:thtodoro/add-mfe

Conversation

@forteddyt
Copy link
Copy Markdown
Contributor

@forteddyt forteddyt commented Jan 19, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Jan 19, 2021

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌LintDiff: 5 Errors, 0 Warnings failed [Detail]
The following errors/warnings are introduced by current PR:
Rule Message
AutoRest exception "readme":"machinelearningservices/resource-manager/readme.md",
"tag":"package-2020-09-01-preview",
"details":"Syntax Error Encountered: Syntax error: end of the stream or a document separator is expected"
AutoRest exception "readme":"machinelearningservices/resource-manager/readme.md",
"tag":"package-2020-09-01-preview",
"details":"Syntax Error Encountered: Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key"
AutoRest exception "readme":"machinelearningservices/resource-manager/readme.md",
"tag":"package-2020-09-01-preview",
"details":"Syntax Error Encountered: Syntax error: duplicate key"
AutoRest exception "readme":"machinelearningservices/resource-manager/readme.md",
"tag":"package-2020-09-01-preview",
"details":"Syntax Error Encountered: Syntax error: duplicate key"
AutoRest exception "readme":"machinelearningservices/resource-manager/readme.md",
"tag":"package-2020-09-01-preview",
"details":"Syntax Error Encountered: Syntax error: expected a single document in the stream,
but found more"
️❌Avocado: 49 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Rule Message
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/ListSkus.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/ListUsages.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/ListVMSizesResult.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/ListWorkspaceFeatures.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/ListWorkspaceQuotasByVMFamily.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/amlComputeListNodes.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/createBasicAKSCompute.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/createBasicAmlCompute.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/createBasicDataFactoryCompute.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/machinelearningservices/resource-manager/readme.md
json: stable/2021-04-01/examples/createComputeInstance.json
️❌ModelValidation: 106 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Rule Message
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tenantId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: resourceId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tenantId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: resourceId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tenantId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: resourceId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identityType
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4631
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/list.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tenantId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/get.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: resourceId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/get.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tenantId
Url: Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json#L4616
JsonUrl: 2020-09-01-preview/examples/OnlineDeployment/get.json
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄[Staging] SDK Track2 Validation inProgress [Detail]
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @forteddyt Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Jan 19, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: end of the stream or a document separator is expected
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:32:12
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:33:0
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:30:0
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: expected a single document in the stream, but found more
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmdout	[Autorest] [OperationAbortedException] Error occurred. Exiting.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-04-27 19:47:12 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-machinelearningservices;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-04-27 19:47:12 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-04-27 19:47:12 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.24 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/machinelearningservices/azure-resourcemanager-machinelearningservices --java.namespace=com.azure.resourcemanager.machinelearningservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
      cmderr	[generate.py] ERROR: Syntax Error Encountered:  Syntax error: end of the stream or a document separator is expected
      cmderr	[generate.py]     - codeBlock_27:2:12
      cmderr	[generate.py] ERROR: Syntax Error Encountered:  Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key
      cmderr	[generate.py]     - codeBlock_27:5:12
      cmderr	[generate.py] ERROR: Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generate.py]     - codeBlock_27:6:0
      cmderr	[generate.py] ERROR: Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generate.py]     - codeBlock_27:3:0
      cmderr	[generate.py] ERROR: Syntax Error Encountered:  Syntax error: expected a single document in the stream, but found more
      cmderr	[generate.py]     - codeBlock_27:2:12
      cmderr	[generate.py] 2021-04-27 19:47:18 ERROR [GENERATE] Autorest fail
      cmderr	[generate.py] 2021-04-27 19:47:55 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-machinelearningservices [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-04-27 19:48:46 DEBUG Got artifact_id: azure-resourcemanager-machinelearningservices
      cmderr	[Inst] 2021-04-27 19:48:46 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-04-27 19:48:46 DEBUG Got artifact: azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-04-27 19:48:46 DEBUG Match jar package: azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-04-27 19:48:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12508/azure-sdk-for-java/azure-resourcemanager-machinelearningservices/azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar\" -o azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-machinelearningservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: end of the stream or a document separator is expected
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:32:12
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:33:0
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:30:0
      cmderr	[Autorest] ERROR: Syntax Error Encountered: Syntax error: expected a single document in the stream, but found more
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmdout	[Autorest] [OperationAbortedException] Error occurred. Exiting.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️❌ azure-sdk-for-python failed [Detail]
    • Failed [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmdout	[automation_generate.sh] [Autorest] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmdout	[automation_generate.sh] [Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:30:0
      cmdout	[automation_generate.sh] [Autorest] ERROR: Syntax Error Encountered: Syntax error: expected a single document in the stream, but found more
      cmdout	[automation_generate.sh] [Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmdout	[automation_generate.sh] [Autorest] [OperationAbortedException] Error occurred. Exiting.
      cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[main.go] [AUTOREST] ERROR: Syntax Error Encountered: Syntax error: end of the stream or a document separator is expected
      cmderr	[main.go] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmderr	[main.go] [AUTOREST] ERROR: Syntax Error Encountered: Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key
      cmderr	[main.go] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:32:12
      cmderr	[main.go] [AUTOREST] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmderr	[main.go] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:33:0
      cmderr	[main.go] [AUTOREST] ERROR: Syntax Error Encountered: Syntax error: duplicate key
      cmderr	[main.go] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:30:0
      cmderr	[main.go] [AUTOREST] ERROR: Syntax Error Encountered: Syntax error: expected a single document in the stream, but found more
      cmderr	[main.go] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md:29:12
      cmderr	[main.go] [ERROR] total 1 error(s):
      cmderr	[main.go] [ERROR] cannot generate readme 'specification/machinelearningservices/resource-manager/readme.md': autorest error with arguments '--use=@microsoft.azure/autorest.go@2.1.180, --go, --verbose, --go-sdk-folder=., --multiapi, --use-onever, --version=V2, --go.license-header=MICROSOFT_MIT_NO_VERSION, ../../../../../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md, --metadata-output-folder=../../../../../azure-rest-api-specs/specification/machinelearningservices/resource-manager':
      cmderr	[main.go] [ERROR] exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go
      warn	Skip package processing as generation is failed
    ️❌ azure-cli-extensions failed [Detail]
    • Failed [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
      cmderr	[Autorest] ERROR: Syntax Error Encountered:  Syntax error: end of the stream or a document separator is expected
      cmderr	[Autorest]     - codeBlock_27:1:1
      cmderr	[Autorest] ERROR: Syntax Error Encountered:  Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key
      cmderr	[Autorest]     - codeBlock_27:1:1
      cmderr	[Autorest] ERROR: Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[Autorest]     - codeBlock_27:1:1
      cmderr	[Autorest] ERROR: Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[Autorest]     - codeBlock_27:1:1
      cmderr	[Autorest] ERROR: Syntax Error Encountered:  Syntax error: expected a single document in the stream, but found more
      cmderr	[Autorest]     - codeBlock_27:1:1
      cmdout	[Autorest] [OperationAbortedException] Error occurred. Exiting.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-cli-extensions]: autorest
      warn	Skip package processing as generation is failed
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 06d9374aeaf1aa5a63b6ab805209d1aa6f70ca5f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • machinelearningservices/resource-manager [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @forteddyt forteddyt added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 19, 2021
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi @forteddyt, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @forteddyt forteddyt changed the title [Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2020-09-01-preview [Hub Generated] Review request for Microsoft.MachineLearningServices to update version preview/2020-09-01-preview Jan 20, 2021
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi, @forteddyt your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 20, 2021
    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Mar 26, 2021

        "createdTimeUtc": {
    

    This should be in systemData. You shouldn't duplicate it inside the resource properties #Closed


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:8568 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Mar 26, 2021

    "ResourceIdentityInArm": {
    

    please mark all managed identity properties readonly that are readonly


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9097 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Mar 26, 2021

        "clientSecretUrl": {
    

    this is not something you expose to the user. Please read through the managed identity implementation/contract docs one more time and ensure your contract is correct #Closed


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9085 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Mar 26, 2021

        "type": {
    

    Don't use "type" as the discriminator on all these definitions. Change it to something more specific like "scheduleType" for schedules, etc... You got exceptions to use "tags", etc... within the property bag but there is no reason to duplicate all top level property names inside your property bag when you can easily use something else #Closed


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:10184 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    @forteddyt
    Copy link
    Copy Markdown
    Contributor Author

        "clientSecretUrl": {
    

    this is not something you expose to the user. Please read through the managed identity implementation/contract docs one more time and ensure your contract is correct

    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9085 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    Could you point me to the "managed identity implementation/contract docs"?

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Mar 30, 2021

    Managed identity docs (more info in the table of contents in that same wiki section). https://armwiki.azurewebsites.net/authorization/managed_identities/MSIOnboardingSteps.html

    @forteddyt
    Copy link
    Copy Markdown
    Contributor Author

    forteddyt commented Apr 2, 2021

    "ResourceIdentityInArm": {
    

    please mark all managed identity properties readonly that are readonly

    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9097 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    From my understanding, Managed Identities are updatable. Our service supports updating them, as well

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Apr 6, 2021

        "identityType": {
    

    "type" was the correct property name


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:8857 in 3c977ff. [](commit_id = 3c977ff, deletion_comment = False)

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Apr 6, 2021

    "ResourceIdentityInArm": {
    

    "principalId" and "tenantId" still need to be marked readonly


    In reply to: 808519549 [](ancestors = 808519549)


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:9097 in 9f78980. [](commit_id = 9f78980, deletion_comment = False)

    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Apr 6, 2021

          "type": "string"
    

    "resourceId" and "tenantId" are not part of the contract. See https://armwiki.azurewebsites.net/authorization/managed_identities/MSIOnboardingUserAssigned.html#resource-definition-response


    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:8849 in 3c977ff. [](commit_id = 3c977ff, deletion_comment = False)

    @forteddyt
    Copy link
    Copy Markdown
    Contributor Author

          "type": "string"
    

    "resourceId" and "tenantId" are not part of the contract. See https://armwiki.azurewebsites.net/authorization/managed_identities/MSIOnboardingUserAssigned.html#resource-definition-response

    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-09-01-preview/mfe.json:8849 in 3c977ff. [](commit_id = 3c977ff, deletion_comment = False)

    I've updated ResourceIdentityInArm's definition (alongside renaming it to ResourceIdentity) in c5e2292. Could you take a look and tell me if it's properly defined? I'll update the example files afterwards

    Comment on lines +28 to +31
    <<<<<<< HEAD
    openapi-type: arm
    tag: package-2020-09-01-preview
    =======
    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey, looks like that we have some conflicts that are not correctly resolved here

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-FixRequiredOnFailure DoNotMerge <valid label in PR review process> use to hold merge after approval

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants